Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to poetry and optimize dependencies #681

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Migrate to poetry and optimize dependencies #681

merged 1 commit into from
Aug 19, 2024

Conversation

ostefano
Copy link
Collaborator

@ostefano ostefano commented Aug 12, 2024 •
edited
Loading

Changes:

  • Migrate build to poetry
  • Migrate doc build to poetry
  • Update doc Makefile
  • Remove unused files / tools
  • Update install documentation
  • Fix lack of REDIS_PW env variable
  • Remove whois and bgpranking modules
  • Add heuristic to load system-installed faup library

@ostefano ostefano marked this pull request as draft August 12, 2024 09:45
@ostefano ostefano force-pushed the refactory branch 5 times, most recently from abbce15 to 1f4b3b1 Compare August 15, 2024 21:01
@ostefano ostefano changed the title WIP Migrate to poetry and optimized dependencies Aug 15, 2024
@ostefano ostefano marked this pull request as ready for review August 15, 2024 21:01
@adulau
Copy link
Member

adulau commented Aug 16, 2024

Sounds great. Thanks a lot for the work. Can you also update the install doc to match the changes?

https://github.com/MISP/misp-modules/blob/main/docs/install.md

@ostefano
Copy link
Collaborator Author

Sure thing. I will also make pushing the package to PyPI part of this PR.

@ostefano ostefano marked this pull request as draft August 16, 2024 17:38
@ostefano ostefano force-pushed the refactory branch 2 times, most recently from b574535 to 978e3b9 Compare August 16, 2024 21:54
@ostefano ostefano changed the title Migrate to poetry and optimized dependencies Migrate to poetry and optimize dependencies Aug 16, 2024
@ostefano ostefano force-pushed the refactory branch 2 times, most recently from 21ae262 to 156649e Compare August 17, 2024 13:49
@ostefano ostefano marked this pull request as ready for review August 17, 2024 14:57
@ostefano
Copy link
Collaborator Author

Change of plans @adulau .
This is ready to be merged.

#685 will be focused on GitHub actions.

This was referenced Aug 18, 2024
Merged
Closed
@adulau adulau merged commit 0e8b7f1 into MISP:main Aug 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ostefano @adulau